Add useGetAggregateFromServerQuery hook #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To view this pull requests documentation preview, visit the following URL: react-query-firebase.invertase.dev/~106 Documentation is deployed and generated using docs.page. |
Ehesp
requested changes
Sep 26, 2024
| : never; | ||
| }; | ||
|
|
||
| export function useGetAggregateFromServerQuery<T extends AggregateSpec>( |
There was a problem hiding this comment.
I think we should change the API spec here, since the aggregates are a requirement, so:
useGetAggregateFromServerQuery(query, {
countOfDocs: count(),
totalHours: sum('hours'),
averageScore: average('score')
});
Let's keep any optional parts in the firestore key and make sure they are all optional values?
There was a problem hiding this comment.
thanks for the clarity here. absolutely, going to adjust here and keep all required parts at the top level and optional parts maintaining them as optional in the firestore key object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
useGetAggregateFromServerQueryhook